-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external handling in Overkiz AtlanticElectricalHeaterWithAdjustableTemperatureSetPoint #84010
Add external handling in Overkiz AtlanticElectricalHeaterWithAdjustableTemperatureSetPoint #84010
Conversation
Hey there @iMicknl, @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@nyroDev - I just got a notification about this because of the bug it's tagged against - I think you've tagged the wrong bug in the description. |
Sorry, I updated the description. |
.../overkiz/climate_entities/atlantic_electrical_heater_with_adjustable_temperature_setpoint.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Thibaut <thibaut@etienne.pw>
Hey guys! Someone know when this fix will be implemented in further update? Thanks for your help 🙏🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to address before merging
.../overkiz/climate_entities/atlantic_electrical_heater_with_adjustable_temperature_setpoint.py
Outdated
Show resolved
Hide resolved
.../overkiz/climate_entities/atlantic_electrical_heater_with_adjustable_temperature_setpoint.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @nyroDev 👍
The requested changes have been implemented
Proposed change
This is a proposal/attempt to fix #83594
When external operating mode is used, Auto will be shown in HVAC mode and preset will be set to external.
When external is set as a preset, the new command setSchedulingType will be used.
Needs dependency bump to add SET_SCHEDULING_TYPE command iMicknl/python-overkiz-api#709
iMicknl/python-overkiz-api@v1.7.2...v1.7.3
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: