-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing preset for overkiz Atlantic APC heating zone #84008
Add missing preset for overkiz Atlantic APC heating zone #84008
Conversation
Hey there @iMicknl, @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to address before merging
homeassistant/components/overkiz/climate_entities/atlantic_pass_apc_heating_zone.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/atlantic_pass_apc_heating_zone.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/atlantic_pass_apc_heating_zone.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/atlantic_pass_apc_heating_zone.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/atlantic_pass_apc_heating_zone.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/climate_entities/atlantic_pass_apc_heating_zone.py
Outdated
Show resolved
Hide resolved
…s_apc_heating_zone.py Co-authored-by: Franck Nijhof <frenck@frenck.nl>
…s_apc_heating_zone.py Co-authored-by: Franck Nijhof <frenck@frenck.nl>
…s_apc_heating_zone.py Co-authored-by: Franck Nijhof <frenck@frenck.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @nyroDev 👍
Another small improvement possibility (for a future PR) is the current dev
supports providing translations for non-standard presets. You might want to consider providing translations for all the presets used by Overkiz.
Happy Holidays! 🎄
../Frenck
Proposed change
This fix issue #83635 by handling the missing heating mode and heating profile from Atlantic APC heating zone in Overkiz integration
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: