Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark repo as safe directory to git config #83755

Merged

Conversation

RoboMagus
Copy link
Contributor

Proposed change

During devcontainer setup script (postCreateCommand) add the HA Core repo to the global Git config safe directories. This circumvents errors caused by the directory not being trusted. Fixes #83753.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added bugfix cla-signed small-pr PRs with less than 30 lines. labels Dec 11, 2022
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Dec 20, 2022
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Jan 7, 2023
@davet2001
Copy link
Contributor

I noticed yesterday that the latest vscode detects when this has occurred and offers a solution via the UI.

But I think still worth having and limiting to devcontainer is a good idea.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @RoboMagus 👍

@frenck frenck merged commit dc000d2 into home-assistant:dev Jan 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2023
@RoboMagus RoboMagus deleted the devcontainer-setup-mark-safe-git branch May 3, 2023 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devcontainer postCreateCommand fails
3 participants