Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore remote discovered devices between remote scanner restarts #83699

Merged
merged 42 commits into from
Dec 11, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 10, 2022

Proposed change

We currently restore the data from dbus for local adapters. We now
implement this for remote adapters as well by saving the discovered devices
to disk between restarts and restore any non-expired devices at startup.

This allows us to solve the following issues with remote scanners:

  • recover from the esphome/shelly getting disconnected/rebooting/restarting/crashing etc
  • connect to BLE devices right away for remote scanners as well to avoid long startup delays waiting for advertisements to come in. ESPHome needs the address type and since we cannot save it on the esp32 to risk running out of ram, as such its currently only available in the BLEDevice object.
  • avoids bluetooth device entries entering a retry state at startup because esphome and shelly start after bluetooth and they do not see the advertisements yet similar to Fix bluetooth device connection failure when device is seen by dbus but not bleak #83281

changelog for deps:
Bluetooth-Devices/bluetooth-adapters@v0.12.0...v0.14.1
home-assistant-libs/home-assistant-bluetooth@v1.8.1...v1.9.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco marked this pull request as ready for review December 11, 2022 03:24
@bdraco bdraco requested a review from a team as a code owner December 11, 2022 03:24
@bdraco bdraco marked this pull request as draft December 11, 2022 04:22
@bdraco
Copy link
Member Author

bdraco commented Dec 11, 2022

Test needs to patch the dbus restore since it makes a socket connection to dbus

@bdraco bdraco marked this pull request as ready for review December 11, 2022 04:33
@bdraco bdraco marked this pull request as draft December 11, 2022 05:35
@bdraco
Copy link
Member Author

bdraco commented Dec 11, 2022

Still mocking missing. Local tests pass on Mac

@bdraco bdraco marked this pull request as ready for review December 11, 2022 07:44
Copy link
Contributor

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@bdraco
Copy link
Member Author

bdraco commented Dec 11, 2022

Thanks

@bdraco bdraco merged commit 9008006 into home-assistant:dev Dec 11, 2022
@bdraco bdraco deleted the esphome_restore_addresses branch December 11, 2022 19:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants