-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore remote discovered devices between remote scanner restarts #83699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
commented
Dec 10, 2022
bdraco
commented
Dec 10, 2022
bdraco
commented
Dec 10, 2022
bdraco
commented
Dec 10, 2022
bdraco
commented
Dec 10, 2022
bdraco
commented
Dec 10, 2022
bdraco
commented
Dec 10, 2022
Test needs to patch the dbus restore since it makes a socket connection to dbus |
Still mocking missing. Local tests pass on Mac |
…esphome_restore_addresses
bachya
approved these changes
Dec 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
We currently restore the data from dbus for local adapters. We now
implement this for remote adapters as well by saving the discovered devices
to disk between restarts and restore any non-expired devices at startup.
This allows us to solve the following issues with remote scanners:
BLEDevice
object.esphome
andshelly
start after bluetooth and they do not see the advertisements yet similar to Fix bluetooth device connection failure when device is seen by dbus but not bleak #83281changelog for deps:
Bluetooth-Devices/bluetooth-adapters@v0.12.0...v0.14.1
home-assistant-libs/home-assistant-bluetooth@v1.8.1...v1.9.0
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: