-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue on Overkiz Domestic Hot water heater entities with away mode #83684
Conversation
Hey there @iMicknl, @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
homeassistant/components/overkiz/water_heater_entities/domestic_hot_water_production.py
Outdated
Show resolved
Hide resolved
is raised when the enum value is missing from OverkizState. I was able to reproduce modifying this line in pyoverkiz: https://github.com/iMicknl/python-overkiz-api/blob/main/tests/test_models.py#L63
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As this entity was added in 2022.12 (see #81538), let’s fix 2022.12.x
#83684) * Don't call set boostMode Duration with 0 to disable boost mode * use states.get() instead of states[] * Revert select states
Breaking change
Proposed change
This is an attempt to fix for #83326
I'm not sure if the target branch should still be dev in this case, sorry if I'm doing it wrong.
Type of change
Additional information
#83326 should be fixed by not calling set boost mode duration with 0
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: