Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only specific packages to be skipped during startup dependency installation #82758

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Nov 26, 2022

Proposed change

Add a --skip-pip-packages command line argument for more granular control over runtime package installation than --skip-pip.

I use the --skip-pip option because I frequently test upgraded/downgraded packages at runtime. When upgrading HA Core, I have to re-launch Core without --skip-pip, let it install updated dependencies for other integrations, manually re-install my own, and then re-launch with --skip-pip.

Example:

hass --skip-pip-packages zigpy,zha-quirks,bellows,zigpy-znp,zigpy-deconz,zigpy-zigate,zigpy-xbee

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery
Copy link
Contributor

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Can be merged when a docs PR is opened.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs PR is opened, and build failure is unrelated.

Going to merge this one in.

Thanks @puddly 👍

@frenck frenck merged commit 8c89943 into home-assistant:dev Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants