Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shelly tests coverage #82642

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Add Shelly tests coverage #82642

merged 3 commits into from
Nov 24, 2022

Conversation

thecode
Copy link
Member

@thecode thecode commented Nov 24, 2022

Proposed change

Add missing tests coverage to bring the integration to 99% coverage, currently there are 6 uncovered lines out of 2308, which will be added in a future PR

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @balloob, @bieniu, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the issue, add the integration domain after the command.

homeassistant/components/shelly/utils.py Outdated Show resolved Hide resolved
tests/components/shelly/test_binary_sensor.py Outdated Show resolved Hide resolved
tests/components/shelly/test_coordinator.py Outdated Show resolved Hide resolved
tests/components/shelly/test_utils.py Outdated Show resolved Hide resolved
@thecode thecode removed the bugfix label Nov 24, 2022
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work,
Thnx @thecode !

@thecode
Copy link
Member Author

thecode commented Nov 24, 2022

Nice work, Thnx @thecode !

Thanks!

@thecode thecode merged commit 1e68e8c into home-assistant:dev Nov 24, 2022
@thecode thecode deleted the shelly-tests branch November 24, 2022 18:07
@thecode thecode mentioned this pull request Nov 24, 2022
19 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants