Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date platform #81948

Merged
merged 22 commits into from
Apr 30, 2023
Merged

Add date platform #81948

merged 22 commits into from
Apr 30, 2023

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Nov 11, 2022 •
edited
Loading

Proposed change

Adds a new date platform. See home-assistant/architecture#811 for summary. Related to #81943 and #81949

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

This was referenced Nov 11, 2022
Merged
Merged
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (demo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of demo can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign demo Removes the current integration label and assignees on the issue, add the integration domain after the command.

@raman325 raman325 mentioned this pull request Nov 16, 2022
Merged
9 tasks
@raman325 raman325 marked this pull request as ready for review November 17, 2022 19:10
@raman325 raman325 requested review from a team and epenet as code owners November 17, 2022 19:10
This was referenced Nov 18, 2022
Merged
Merged
Merged
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 19, 2023
@frenck
Copy link
Member

frenck commented Feb 19, 2023

Dear bot, this is definitely not stale (it could use a rebase though).

@github-actions github-actions bot removed the stale label Feb 19, 2023
frenck
frenck requested changes Apr 17, 2023
View reviewed changes
homeassistant/components/date/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/date/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/date/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/date/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/date/__init__.py Show resolved Hide resolved
homeassistant/components/date/__init__.py Show resolved Hide resolved
homeassistant/const.py Outdated Show resolved Hide resolved
homeassistant/components/date/strings.json Outdated Show resolved Hide resolved
homeassistant/components/date/manifest.json Show resolved Hide resolved
tests/components/date/test_init.py Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft April 17, 2023 10:16
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@raman325 raman325 marked this pull request as ready for review April 19, 2023 17:03
@home-assistant home-assistant bot requested a review from frenck April 19, 2023 17:03
frenck
frenck approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me ✅

Going to mark it draft until after the beta for 2023.5 is shipped, so we can get all of the related entity components in a single release.

../Frenck

@frenck frenck marked this pull request as draft April 19, 2023 18:58
frenck
frenck requested changes Apr 22, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have discussed the attributes, and decided to remove them for now. They are duplicates of the actual state.

../Frenck

homeassistant/components/date/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/date/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/date/const.py Outdated Show resolved Hide resolved
homeassistant/components/date/recorder.py Outdated Show resolved Hide resolved
homeassistant/components/date/strings.json Outdated Show resolved Hide resolved
tests/components/date/test_init.py Outdated Show resolved Hide resolved
tests/components/date/test_init.py Outdated Show resolved Hide resolved
tests/components/date/test_init.py Outdated Show resolved Hide resolved
tests/components/date/test_recorder.py Outdated Show resolved Hide resolved
@frenck frenck marked this pull request as ready for review April 30, 2023 18:32
@home-assistant home-assistant bot requested a review from frenck April 30, 2023 18:32
@frenck
Copy link
Member

frenck commented Apr 30, 2023

2023.5 beta has been cut, taking it out of draft.

frenck
frenck approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @raman325 👍

@frenck frenck merged commit d138bbe into home-assistant:dev Apr 30, 2023
@raman325 raman325 deleted the date branch April 30, 2023 18:45
raman325 added a commit to raman325/home-assistant that referenced this pull request Apr 30, 2023
@raman325
Merge branch 'dev' into datetime_2
19246c7 
* dev: (581 commits)
  Only store and pass around coordinator in Rituals Perfume Genie (home-assistant#92298)
  Avoid returning statistics columns that the metadata knows are impossible (home-assistant#92095)
  Add `date` platform (home-assistant#81948)
  Prevent pysnmp from being installed as it does not work with newer python (home-assistant#92292)
  Use SnapshotAssertion in Renault tests (home-assistant#90778)
  Home Connect add WasherDryer support (home-assistant#90673)
  Move lastfm constants to separate file (home-assistant#92289)
  Fix august lock state when API reports locking and locked with the same timestamp (home-assistant#92276)
  Ensure onvif webhook can be registered (home-assistant#92295)
  Bump beacontools to fix conflict with construct<2.10 and >=2.8.16 (home-assistant#92293)
  Bump pynina to 0.3.0 (home-assistant#92286)
  Fix mqtt not available when starting snips (home-assistant#92296)
  Extract Rituals Perfume Genie DataUpdateCoordinator into module (home-assistant#92284)
  Bump bleak to 0.20.2 (home-assistant#92294)
  Add missing fstrings in Local Calendar (home-assistant#92288)
  Remove myself from switcher_kis codeowners (home-assistant#92277)
  Handle AttributeError from wrong port in ONVIF config flow (home-assistant#92272)
  Auto repair incorrect collation on MySQL schema (home-assistant#92270)
  Update orjson to 3.8.11 (home-assistant#92228)
  Update coverage to 7.2.4 (home-assistant#92229)
  ...
@epenet
Copy link
Contributor

epenet commented May 1, 2023

Should it be added to

core/.core_files.yaml

Line 14 in 7b5d26d

base_platforms: &base_platforms
?

@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@epenet epenet Awaiting requested review from epenet

Assignees
No one assigned
Labels
cla-signed core has-tests integration: date integration: demo new-feature new-integration Quality Scale: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raman325 @frenck @epenet