Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating multiple ElkM1 systems with TLS 1.2 #81627

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 5, 2022

Proposed change

urlparse couldn't handle the _ in the protocol scheme so we need to use the one from the lib.

fixes #81516

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco added this to the 2022.11.2 milestone Nov 5, 2022
@home-assistant
Copy link

home-assistant bot commented Nov 5, 2022

Hey there @gwww, mind taking a look at this pull request as it has been labeled with an integration (elkm1) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of elkm1 can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign elkm1 Removes the current integration label and assignees on the issue, add the integration domain after the command.

@gwww
Copy link
Contributor

gwww commented Nov 5, 2022

LGTM!

@MartinHjelmare MartinHjelmare merged commit 2bea775 into home-assistant:dev Nov 7, 2022
@bdraco
Copy link
Member Author

bdraco commented Nov 7, 2022

thanks

frenck pushed a commit that referenced this pull request Nov 8, 2022
@frenck frenck mentioned this pull request Nov 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not add two secure instances of Elk M1 when using TLS 1.2
4 participants