Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugwise to v0.25.7 #81612

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Bump plugwise to v0.25.7 #81612

merged 1 commit into from
Nov 5, 2022

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Nov 5, 2022

Proposed change

Bump plugwise to v0.25.7
https://github.com/plugwise/python-plugwise/releases/tag/v0.25.7
https://github.com/plugwise/python-plugwise/releases/tag/v0.25.6
https://github.com/plugwise/python-plugwise/releases/tag/v0.25.4
plugwise/python-plugwise@v0.25.3...v0.25.7

Please include this update in one of the coming 2022.11.x patch releases, thanks!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 5, 2022

Hey there @CoMPaTech, @brefra, @frenck, mind taking a look at this pull request as it has been labeled with an integration (plugwise) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of plugwise can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign plugwise Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco bdraco added this to the 2022.11.2 milestone Nov 5, 2022
@bdraco
Copy link
Member

bdraco commented Nov 5, 2022

Thanks for bumping the dependency! Please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.
    This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks 👍

@bouwew
Copy link
Contributor Author

bouwew commented Nov 5, 2022

Sorry, I know this :(
The requested info was added to the top message.

@bdraco
Copy link
Member

bdraco commented Nov 5, 2022

Sorry, I know this :(
The requested info was added to the top message.

No worries. Can't say I've never forgotten to do it as well

@bouwew
Copy link
Contributor Author

bouwew commented Nov 5, 2022

@bdraco Appreciate the reviewing and approval, thanks!

@bdraco bdraco merged commit 5f9f956 into home-assistant:dev Nov 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugwise Integration does not work
3 participants