Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeating SSDP errors by checking address scope_ids and proper hostname #81611

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

StevenLooman
Copy link
Contributor

@StevenLooman StevenLooman commented Nov 5, 2022

Proposed change

Bump async-upnp-client to 0.32.2. This fixes two issues:

StevenLooman/async_upnp_client@0.32.1...0.32.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Links to changes in async-upnp-client:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 5, 2022

Hey there @chishm, mind taking a look at this pull request as it has been labeled with an integration (dlna_dms) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of dlna_dms can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign dlna_dms Removes the current integration label and assignees on the issue, add the integration domain after the command.

@home-assistant
Copy link

home-assistant bot commented Nov 5, 2022

Hey there @chishm, mind taking a look at this pull request as it has been labeled with an integration (dlna_dmr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of dlna_dmr can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign dlna_dmr Removes the current integration label and assignees on the issue, add the integration domain after the command.

@home-assistant
Copy link

home-assistant bot commented Nov 5, 2022

Hey there @chemelli74, @epenet, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of samsungtv can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign samsungtv Removes the current integration label and assignees on the issue, add the integration domain after the command.

@home-assistant
Copy link

home-assistant bot commented Nov 5, 2022

Hey there @zewelor, @shenxn, @starkillerOG, @alexyao2015, mind taking a look at this pull request as it has been labeled with an integration (yeelight) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of yeelight can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign yeelight Removes the current integration label and assignees on the issue, add the integration domain after the command.

@StevenLooman StevenLooman changed the title Bump async-upnp-client==0.32.2 Fix repeating SSDP errors by checking address scope_ids and proper hostname Nov 5, 2022
@bdraco bdraco added this to the 2022.11.2 milestone Nov 5, 2022
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgraded my production with this. Discovery still working. No unexplained errors

@bdraco bdraco merged commit a635e9c into home-assistant:dev Nov 5, 2022
@StevenLooman StevenLooman deleted the fix_81461_81459 branch November 6, 2022 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError related to async_upnp_client.ssdp_listener
5 participants