-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use Celsius in Shelly integration, part 2 #81602
Conversation
Hey there @balloob, @thecode, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smol typo - and should there be a test for this?
Co-authored-by: Aarni Koskela <akx@iki.fi>
@akx Currently, we do not have tests for sensor platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Gen1 DW2 and Gen2 Shelly Plus H&T.
Many thanks @bieniu for debugging this issue.
Breaking change
Proposed change
We want integration internally to always use Celsius, also for sleeping devices like H&T. This is a continuation of #80842.
EDIT:
After the discussion with @thecode I changed the code, now the unit of measurement is also restored from registry, as is the value. When the device sends a new state, the unit is set based on
entity_description
.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: