Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use Celsius in Shelly integration, part 2 #81602

Merged
merged 3 commits into from
Nov 6, 2022
Merged

Always use Celsius in Shelly integration, part 2 #81602

merged 3 commits into from
Nov 6, 2022

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Nov 5, 2022

Breaking change

Proposed change

We want integration internally to always use Celsius, also for sleeping devices like H&T. This is a continuation of #80842.

EDIT:
After the discussion with @thecode I changed the code, now the unit of measurement is also restored from registry, as is the value. When the device sends a new state, the unit is set based on entity_description.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 5, 2022

Hey there @balloob, @thecode, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bieniu bieniu changed the title Fix temperature value conversion for sleeping Shelly devices Always use Celsius in Shelly integration, part 2 Nov 6, 2022
@bieniu bieniu marked this pull request as ready for review November 6, 2022 09:23
@bieniu bieniu added this to the 2022.11.2 milestone Nov 6, 2022
Copy link
Contributor

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smol typo - and should there be a test for this?

homeassistant/components/shelly/sensor.py Outdated Show resolved Hide resolved
Co-authored-by: Aarni Koskela <akx@iki.fi>
@bieniu
Copy link
Member Author

bieniu commented Nov 6, 2022

@akx Currently, we do not have tests for sensor platform.

Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Gen1 DW2 and Gen2 Shelly Plus H&T.
Many thanks @bieniu for debugging this issue.

@bieniu bieniu merged commit df7000f into home-assistant:dev Nov 6, 2022
@bieniu bieniu deleted the shelly-fix-c-f-conv branch November 6, 2022 20:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Always use Celsius in Shelly integration" is a breaking change
6 participants