Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gcal_sync to 4.0.0 #81562

Merged
merged 3 commits into from
Nov 6, 2022
Merged

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Nov 4, 2022

Proposed change

Bump gcal_sync to 4.0.0 to fix a bug in how recurring events are expanded with respect to timezones, impacting DST.

  • Fixes some recurring event expansion rules based on underlying issues in dateutil.rrule that does not handle parameters correctly
  • Fixes handling of timezones returned from the API when used as recurrence rule start times to handle things like dst transitions
  • There are additional changes in gcal_sync, for more future looking efforts (writable calendar) that included more stricly enforcing required fields like accessRole in the API responses, and some google tests also needed to be updated. I was maintaining patch releases with minor updates, but the rewrite for recurring event expansion bugs was large enough it didn't seem worth it anymore since it included a breaking change.

Changelog: allenporter/gcal_sync@2.2.3...4.0.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@allenporter allenporter changed the title Bump gcal_sync to 2.2.4 Bump gcal_sync to 4.0.0 Nov 5, 2022
@MartinHjelmare
Copy link
Member

There are test failures.

@allenporter
Copy link
Contributor Author

Re-running with fixes. I've updated the PR description with the other changes in gcal_sync included, and re-ran local testing.

@allenporter allenporter merged commit 2ad1d31 into home-assistant:dev Nov 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
@allenporter allenporter deleted the calendar-tz branch December 23, 2022 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.