Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for oralb IO Series 4 #81110

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 27, 2022

Proposed change

Add support for oralb IO Series 4
changelog: Bluetooth-Devices/oralb-ble@v0.5.0...v0.6.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@balloob
Copy link
Member

balloob commented Oct 27, 2022

CleanShot 2022-10-27 at 15 16 53
CleanShot 2022-10-27 at 15 17 13

@balloob
Copy link
Member

balloob commented Oct 27, 2022

Also see this unknown pressure when I press power button to turn it off.

image

@bdraco
Copy link
Member Author

bdraco commented Oct 27, 2022

I have an IO Series 8 coming so I'll map the pressure and states from that when it shows up as they are likely the same and do a followup PR (should show up tomorrow..taking a while because I bought a closeout color that nobody wanted)

@balloob balloob merged commit c21fb22 into home-assistant:dev Oct 27, 2022
balloob pushed a commit that referenced this pull request Oct 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants