Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UniFi outlet switches #80738

Merged
merged 3 commits into from
Oct 23, 2022

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Oct 21, 2022

Breaking change

Proposed change

Simplify the outlet implementation. Shares the same design as #80566

Library bump mainly contains the new outlet implementation utilised with this PR
Kane610/aiounifi@v40...v41

I also aim to use entity_descriptions and align the entity classes to remove duplicated code.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Oct 21, 2022

CI fix is here #80737

@Kane610 Kane610 force-pushed the unifi-rewrite_outlet_switches branch from e3ac595 to bd318f8 Compare October 21, 2022 17:58
@Kane610 Kane610 force-pushed the unifi-rewrite_outlet_switches branch from af5e9f7 to 961b5c6 Compare October 23, 2022 17:36
@Kane610
Copy link
Member Author

Kane610 commented Oct 23, 2022

Thank you @bdraco 🎉

@Kane610 Kane610 merged commit 0444dd7 into home-assistant:dev Oct 23, 2022
@Kane610 Kane610 deleted the unifi-rewrite_outlet_switches branch October 23, 2022 18:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants