Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bleak to 0.19.0 #80349

Merged
merged 35 commits into from
Oct 15, 2022
Merged

Bump bleak to 0.19.0 #80349

merged 35 commits into from
Oct 15, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 14, 2022

Proposed change

Bump bleak to 0.19.0

There are breaking changes in the library but they are not user facing. Breaking changes in the lib only affect Home Assistant development. These changes likely do not affect libraries except for the first one which has a transition time.:

In exchange for the breaking changes we avoid almost all the linear searches for BLEDevice or AdvertisementData, as well as the ability to exchange some coroutines for callback functions which allows the manager to be refactored to be much more efficient at handling unavailable devices.

Future PRs to handle the deprecation after this PR

  • At least following packages will need an update as they use device.rssi but they will come in future PRs:

Sent upstream issue

Sent upstream PR

Completed or has PR

Semi-related to this PR, but I noticed we are missing docs for

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco marked this pull request as ready for review October 15, 2022 01:29
@balloob balloob merged commit d12cbab into home-assistant:dev Oct 15, 2022
@bdraco
Copy link
Member Author

bdraco commented Oct 15, 2022

Thanks. I'll start working on the libs.

I also found a race when there are multiple non connectable scanners and connectable scanners and the closest one to the device is non connectable. Will work on a fix for that once I get a valid test written. Doesn't look like we can fix that in a patch release but I expect I can have it worked out for 2022.11 and it's less likely to be a concern anyways now that esphome devices are connectable

@bdraco
Copy link
Member Author

bdraco commented Oct 15, 2022

I also found a race when there are multiple non connectable scanners and connectable scanners and the closest one to the device is non connectable. Will work on a fix for that once I get a valid test written. Doesn't look like we can fix that in a patch release but I expect I can have it worked out for 2022.11 and it's less likely to be a concern anyways now that esphome devices are connectable

Fixed the race here #80388

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants