-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bleak to 0.19.0 #80349
Bump bleak to 0.19.0 #80349
Conversation
Thanks. I'll start working on the libs. I also found a race when there are multiple non connectable scanners and connectable scanners and the closest one to the device is non connectable. Will work on a fix for that once I get a valid test written. Doesn't look like we can fix that in a patch release but I expect I can have it worked out for 2022.11 and it's less likely to be a concern anyways now that esphome devices are connectable |
Fixed the race here #80388 |
Proposed change
Bump bleak to 0.19.0
There are breaking changes in the library but they are not user facing. Breaking changes in the lib only affect Home Assistant development. These changes likely do not affect libraries except for the first one which has a transition time.:
.rssi
property has moved from theBLEDevice
to theAdvertisementData
(its on both during transition)AdvertisementData
no longer have defaults and must all be set (this breaks many tests)In exchange for the breaking changes we avoid almost all the linear searches for
BLEDevice
orAdvertisementData
, as well as the ability to exchange some coroutines for callback functions which allows the manager to be refactored to be much more efficient at handling unavailable devices.Future PRs to handle the deprecation after this PR
device.rssi
but they will come in future PRs:Sent upstream issue
Sent upstream PR
Completed or has PR
BluetoothServiceInfo
abstraction so it will already workBluetoothServiceInfo
abstraction so it will already workSemi-related to this PR, but I noticed we are missing docs for
async_last_service_info
Update bluetooth documentation for bleak 0.19 changes developers.home-assistant#1497Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: