Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugwise to v0.25.2 and adapt climate #80347

Merged
merged 9 commits into from
Oct 16, 2022

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Oct 14, 2022

Proposed change

Bump plugwise to v0.25.2 - https://github.com/plugwise/python-plugwise/releases/tag/v0.25.2
Bump plugwise to v0.25.1 - https://github.com/plugwise/python-plugwise/releases/tag/v0.25.1
This update allows updating the plugwise climate platform to support cooling, via hvac_mode heat_cool.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @CoMPaTech, @brefra, @frenck, mind taking a look at this pull request as it has been labeled with an integration (plugwise) you are listed as a code owner for? Thanks!

@bouwew bouwew marked this pull request as draft October 15, 2022 18:58
@bouwew
Copy link
Contributor Author

bouwew commented Oct 15, 2022

Back to draft, a bug has surfaced.

@bouwew bouwew changed the title Bump plugwise to v0.25.1 and adapt climate Bump plugwise to v0.25.2 and adapt climate Oct 16, 2022
@bouwew bouwew marked this pull request as ready for review October 16, 2022 11:36
homeassistant/components/plugwise/climate.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/climate.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/climate.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/climate.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/climate.py Outdated Show resolved Hide resolved
bouwew and others added 2 commits October 16, 2022 16:43
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @bouwew 👍

@frenck frenck merged commit f566664 into home-assistant:dev Oct 16, 2022
@bouwew
Copy link
Contributor Author

bouwew commented Oct 17, 2022

@frenck Thanks for reviewing and approval!

@bouwew bouwew deleted the plugwise_0_25_1 branch October 17, 2022 07:15
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown error occured during connecting to Plugwise Smile
3 participants