Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump HAP-python to fix pairing with iOS 16 #80301

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 14, 2022

Proposed change

Using the ha- fork until upstream has time to pickup and merge pending PRs. The plan is to revert back to upstream HAP-python when its back in sync.

Fixes #79305 Fixes #79304

changelog: ikalchev/HAP-python@v4.5.0...bdraco:ha-HAP-python:v4.5.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Using the ha- fork until upstream can pickup and merge
pending PRs. The plan is to revert back to upstream
HAP-python when its back in sync

Fixes home-assistant#79305 Fixes home-assistant#79304
@bdraco
Copy link
Member Author

bdraco commented Oct 14, 2022

I tested this against dev but I need to test against 2022.10.x which I will try to do later tonight after dinner

@bdraco bdraco marked this pull request as ready for review October 14, 2022 06:28
@bdraco
Copy link
Member Author

bdraco commented Oct 14, 2022

Tested as a custom component on 2022.10.x as well https://github.com/bdraco/homekit

@MartinHjelmare MartinHjelmare merged commit d327355 into home-assistant:dev Oct 14, 2022
@bdraco
Copy link
Member Author

bdraco commented Oct 14, 2022

Thanks

balloob pushed a commit that referenced this pull request Oct 14, 2022
Using the ha- fork until upstream can pickup and merge
pending PRs. The plan is to revert back to upstream
HAP-python when its back in sync

Fixes #79305 Fixes #79304
@balloob balloob mentioned this pull request Oct 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.