Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ssocr to docker to support Seven Segments Display #8028

Merged
merged 3 commits into from
Jun 16, 2017
Merged

Adding ssocr to docker to support Seven Segments Display #8028

merged 3 commits into from
Jun 16, 2017

Conversation

MartyTremblay
Copy link
Contributor

Description:

Cloning and building ssocr in Docker image to support Seven Segments Display Image Processing Component

Related issue (if applicable): fixes #7774

Pull request in home-assistant.github.io with documentation (if applicable):

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [N/A] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • [N/A] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • [N/A] New dependencies are only imported inside functions that use them ([example][ex-import]).
  • [N/A] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • [N/A] New files were added to .coveragerc.

If the code does not interact with devices:

  • [N/A] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • [N/A] Tests have been added to verify that the new code works.

@homeassistant
Copy link
Contributor

Hi @MartyTremblay,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@mention-bot
Copy link

@MartyTremblay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @michaelarnauts, @balloob and @mathewpeterson to be potential reviewers.

@MartyTremblay
Copy link
Contributor Author

It appears that the CI tests failed for other reasons.

@balloob
Copy link
Member

balloob commented Jun 15, 2017

In the docs it states that we can just do apt-get install ssocr. I prefer we add that instead of having to add a new install script.

@MartyTremblay
Copy link
Contributor Author

Yes, that's correct. However, when I did an apt-get update and then apt-get install ssocr in my hass container, the package manager complained that it did not find ssocr to be installed. I'm guessing that the python:3.6/jessie docker image that hass is based on is missing a repo.

I'll explore this further and will report back soon.

@MartyTremblay
Copy link
Contributor Author

Just confirmed that ssocr is not part of any debian-based distros. The only way to install it on Linux is to build it.
https://www.unix-ag.uni-kl.de/~auerswal/ssocr/ (Official Site)

https://packages.debian.org/search?searchon=contents&keywords=ssocr&mode=filename&suite=stable&arch=any (Debian Package Search)

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks fine then!

@balloob balloob merged commit a3a702b into home-assistant:dev Jun 16, 2017
@balloob balloob mentioned this pull request Jun 16, 2017
@MartyTremblay MartyTremblay deleted the ssocr-docker-support branch June 16, 2017 10:17
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seven Segments Display 'ssocr' not included in Docker image
4 participants