-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ssocr to docker to support Seven Segments Display #8028
Adding ssocr to docker to support Seven Segments Display #8028
Conversation
Hi @MartyTremblay, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
@MartyTremblay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @michaelarnauts, @balloob and @mathewpeterson to be potential reviewers. |
It appears that the CI tests failed for other reasons. |
In the docs it states that we can just do |
Yes, that's correct. However, when I did an I'll explore this further and will report back soon. |
Just confirmed that ssocr is not part of any debian-based distros. The only way to install it on Linux is to build it. https://packages.debian.org/search?searchon=contents&keywords=ssocr&mode=filename&suite=stable&arch=any (Debian Package Search) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, looks fine then!
Description:
Cloning and building ssocr in Docker image to support Seven Segments Display Image Processing Component
Related issue (if applicable): fixes #7774
Pull request in home-assistant.github.io with documentation (if applicable):
Example entry for
configuration.yaml
(if applicable):N/A
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
tox
run successfully. Your PR cannot be merged unless tests passREQUIREMENTS
variable ([example][ex-requir]).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices:
tox
run successfully. Your PR cannot be merged unless tests pass