Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Météo-France to 1.1.0 #80255

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Conversation

Quentame
Copy link
Member

@Quentame Quentame commented Oct 13, 2022

Proposed change

Lib bump containing dependency bumps : https://github.com/hacf-fr/meteofrance-api/releases/tag/v1.1.0

Fixes an issue from @balloob about pytz version resolution on pip : hacf-fr/meteofrance-api#443

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Quentame Quentame changed the title Bump Météo-France to 1.0.2 Bump Météo-France to 1.1.0 Oct 13, 2022
@homeassistant
Copy link
Contributor

Hey there @hacf-fr, @oncleben31, mind taking a look at this pull request as it has been labeled with an integration (meteo_france) you are listed as a code owner for? Thanks!

Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably need to update the number of dependency conflicts from 4 to 3 here:

core/script/pip_check

Lines 4 to 6 in d80c0dd

# Number of existing dependency conflicts
# Update if a PR resolve one!
DEPENDENCY_CONFLICTS=4

@Quentame
Copy link
Member Author

You'll probably need to update the number of dependency conflicts from 4 to 3 here:

core/script/pip_check

Lines 4 to 6 in d80c0dd

# Number of existing dependency conflicts
# Update if a PR resolve one!
DEPENDENCY_CONFLICTS=4

Indeed, PR resolves a dependency conflict with pytz (noticed here hacf-fr/meteofrance-api#443), I updated this check.

Thanks ! ❤️

@Quentame
Copy link
Member Author

Failed pylint & tests checks are not related to this PR

@cdce8p
Copy link
Member

cdce8p commented Oct 13, 2022

Failed pylint & tests checks are not related to this PR

👍🏻 However, we should wait until at least the pytest runs don't outride fail anymore. I opened #80258 to work around the issue with iaqualink.

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks!

@cdce8p
Copy link
Member

cdce8p commented Oct 13, 2022

Only logbook tests are failing now. Those have been fixed in another PR already.

@cdce8p cdce8p merged commit 3379e14 into home-assistant:dev Oct 13, 2022
@Quentame Quentame deleted the meteo_france/bump branch October 13, 2022 20:43
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants