-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Météo-France to 1.1.0 #80255
Bump Météo-France to 1.1.0 #80255
Conversation
53900a7
to
759a68c
Compare
Hey there @hacf-fr, @oncleben31, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll probably need to update the number of dependency conflicts from 4
to 3
here:
Lines 4 to 6 in d80c0dd
# Number of existing dependency conflicts | |
# Update if a PR resolve one! | |
DEPENDENCY_CONFLICTS=4 |
Indeed, PR resolves a dependency conflict with pytz (noticed here hacf-fr/meteofrance-api#443), I updated this check. Thanks ! ❤️ |
Failed pylint & tests checks are not related to this PR |
👍🏻 However, we should wait until at least the pytest runs don't outride fail anymore. I opened #80258 to work around the issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks!
Only logbook tests are failing now. Those have been fixed in another PR already. |
Proposed change
Lib bump containing dependency bumps : https://github.com/hacf-fr/meteofrance-api/releases/tag/v1.1.0
Fixes an issue from @balloob about pytz version resolution on pip : hacf-fr/meteofrance-api#443
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: