Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mutagen to 1.46.0 #80004

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Update mutagen to 1.46.0 #80004

merged 2 commits into from
Oct 11, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Oct 10, 2022

Proposed change

Updates mutagen to 1.46.0
Release notes: https://github.com/quodlibet/mutagen/releases/tag/release-1.46.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hey there @pvizeli, mind taking a look at this pull request as it has been labeled with an integration (tts) you are listed as a code owner for? Thanks!

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 10, 2022
@thecode
Copy link
Member

thecode commented Oct 10, 2022

Removing smash as it looks like the failure is due to this bump

@thecode thecode removed the smash Indicator this PR is close to finish for merging or closing label Oct 10, 2022
@frenck
Copy link
Member Author

frenck commented Oct 10, 2022

Hmm, interesting didn't catch that locally. I will take a look.

Comment on lines +621 to +623
tts_file["artist"] = ID3Text(encoding=3, text=artist) # type: ignore[no-untyped-call]
tts_file["album"] = ID3Text(encoding=3, text=album) # type: ignore[no-untyped-call]
tts_file["title"] = ID3Text(encoding=3, text=message) # type: ignore[no-untyped-call]
Copy link
Member Author

@frenck frenck Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutagen expresses itself to PEP561 compatible by being type (py.typed is present as well), however, ID3Text() (which inherits from Frame()) is not typed...

https://github.com/quodlibet/mutagen/blob/d98d92736c071811838d76a6ed3731b26089fc6f/mutagen/id3/_frames.py#L55

For us there is no other option than ignoring it.

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 11, 2022
@thecode thecode merged commit 8bc9aa9 into dev Oct 11, 2022
@thecode thecode deleted the frenck-2022-1893 branch October 11, 2022 17:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core dependency dependency-bump Hacktoberfest integration: tts small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants