-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pySwitchbot to 0.19.15 #79972
Bump pySwitchbot to 0.19.15 #79972
Conversation
Hey there @Danielhiversen, @RenierM26, @murtas, @Eloston, mind taking a look at this pull request as it has been labeled with an integration ( |
Hi @bdraco, deviceChain": 1, in the adv data should indicate if the curtain is grouped or not. Can't remember if it's 1 for single device or 0. I was looking at a way to determine the "master" to simplify the discovery and device setup but could not test all the combinations. |
Thanks @RenierM26 I’ll do some more experimenting in the morning |
@RenierM26 bit 4 here seems to indicate if it’s a child device but I’m not 100% sure that’s correct as the documentation is a bit unclear / lacking |
@RenierM26 it seems to be set even if it's not grouped for me. The docs say it's the length of the chain but it seems to always be 1 for both the group and ungrouped ones |
I checked another device and deviceChain is set even if its not grouped so I'm going to move forward this solution at it seems to have the best chance to solving the issue
|
Was hoping this would fix reliability issues with my switchbot curtains. Running a set of them as a pair driven by ESP bluetooth proxies. @bdraco - Happy to provide any logs or contribute to another issue or PR if relevant. |
@dadcoachengineer This is a merged PR, which might not be the ideal place to report issues. If you are still experiencing issues, please, open an issue instead (as that can be tracked, until the issues closes). |
Proposed change
Switchbot curtain groups use one set of commands, while some devices use another set of commands. Since we don't know which command set to use (and there is no documentation available for these), we now send both. I ended up buying a second switchbot curtain device to make this sure this strategy works. With sending both command sets the device works in grouped mode to control both curtains, and ungrouped mode to control itself only.
This originally broke in #78857 when the command set was changed
The hope is that by sending both commands we won't regress #78175 but since I could never replicate the issue I can't be sure it won't, but this seems like a better strategy than a full revert which was the other option.
fixes #79827
changelog: sblibs/pySwitchbot@0.19.13...0.19.15
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: