-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make home assistant discoverable via UPnP/SSDP #79820
Make home assistant discoverable via UPnP/SSDP #79820
Conversation
Needs a |
Ah yes... tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
|
||
asyncio.create_task(scanner.async_start()) | ||
hass.create_task(scanner.async_start()) | ||
hass.create_task(server.async_start()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the async api here since we're inside the event loop. Please use hass.async_create_task
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this but then the unit tests won't wait for it when using I misread your comment. I'll pick this up with a later PR.hass.async_block_till_done()
.
Proposed change
Make Home Assistant discoverable via UPnP/SSDP and show up in Windows Network.
Type of change
Additional information
async-upnp-client
is bumped to 0.32.0. Changes to it:Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: