Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make home assistant discoverable via UPnP/SSDP #79820

Merged
merged 13 commits into from
Oct 15, 2022

Conversation

StevenLooman
Copy link
Contributor

@StevenLooman StevenLooman commented Oct 7, 2022

Proposed change

Make Home Assistant discoverable via UPnP/SSDP and show up in Windows Network.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

async-upnp-client is bumped to 0.32.0. Changes to it:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@StevenLooman
Copy link
Contributor Author

StevenLooman commented Oct 7, 2022

Needs a async-upnp-client release which is not ready yet, thus WIP.

@StevenLooman StevenLooman marked this pull request as ready for review October 10, 2022 18:39
@StevenLooman
Copy link
Contributor Author

Ready for a round of reviews @bdraco @balloob.

@StevenLooman
Copy link
Contributor Author

Ah yes... tests...

@StevenLooman StevenLooman requested a review from a team as a code owner October 12, 2022 18:57
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@balloob balloob merged commit 731f618 into home-assistant:dev Oct 15, 2022

asyncio.create_task(scanner.async_start())
hass.create_task(scanner.async_start())
hass.create_task(server.async_start())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the async api here since we're inside the event loop. Please use hass.async_create_task.

Copy link
Contributor Author

@StevenLooman StevenLooman Oct 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this but then the unit tests won't wait for it when using hass.async_block_till_done(). I misread your comment. I'll pick this up with a later PR.

@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Oct 16, 2022
@StevenLooman StevenLooman deleted the 31038_discoverable_via_upnp branch October 16, 2022 15:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependency Hacktoberfest integration: ssdp new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Home Assistant discoverable via SSDP
6 participants