-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Overkiz async_execute_commands #79576
Implement Overkiz async_execute_commands #79576
Conversation
Hey there @iMicknl, @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration ( |
Marked as draft as it's waiting further discussion and implementing details may need to change |
…e integration (home-assistant#101196) * Allow setting hvac mode through set_temperature climate method * Suggested code simplification when reading hvac mode Co-authored-by: G Johansson <goran.johansson@shiftit.se> * Remove unnecessary temperature unit handling from set temperature with hvac mode tests --------- Co-authored-by: G Johansson <goran.johansson@shiftit.se>
Co-authored-by: Franck Nijhof <git@frenck.dev>
* Bump dbus-fast to 2.13.0 changelog: Bluetooth-Devices/dbus-fast@v2.12.0...v2.13.0 * no change re-release since upload failed due to running out of space on pypi
* add 4 sensors * no need for extra class
* Fix 5B Gas meter in dsmr In commit 1b73219 the gas meter broke for 5B. As the change can't be reverted easily without removing the peak usage sensors, we implement a workaround. The first MBUS_METER_READING2 value will contain the gas meter data just like the previous BELGIUM_5MIN_GAS_METER_READING did. But this without the need to touch dsmr_parser (version). Fixes: home-assistant#103306, home-assistant#103293 * Use parametrize * Apply suggestions from code review Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> * Add additional tests + typo fix --------- Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>
…3640) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…102967) * Add support for deleting To-do items in Google Tasks * Cleanup multipart test * Fix comments * Add additional error checking to increase coverage * Apply suggestions and fix tests
Co-authored-by: Thibaut <thibaut@etienne.pw>
…tiple_commands' into overkiz/execute_multiple_commands
Oops, my merge/rebase messed up the whole PR. I'm closing this PR and start a new one to not bother all of you... |
Breaking change
Proposed change
While implementing a new entity in PR #78659, I noticed multiple commands was always executing one by one.
This is not usaly a problem for simple entity because they call one command at once.
But for climate entities in the Atlantic/Somfy world, they usually need multiple commands to work correctly.
Doing only 1 call with multiple commands instead of multiple call for each command is great because:
The current entity that will benefit this change for now are:
I will do the changes on other entity when design of the function is correct and somfy_thermostat is validated
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: