Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate conversion utilities #78957

Merged
merged 5 commits into from
Sep 28, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Sep 22, 2022

Breaking change

The distance, pressure, speed, temperature and volume utilities is now deprecated. Please use the unit_conversion converters instead.

Proposed change

Deprecate distance, pressure, speed, temperature and volume utilities

Needs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@epenet epenet requested a review from a team as a code owner September 22, 2022 14:57
@homeassistant homeassistant added cla-signed core deprecation Indicates a breaking change to happen in the future integration: template integration: weather small-pr PRs with less than 30 lines. labels Sep 22, 2022
@homeassistant
Copy link
Contributor

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (weather) you are listed as a code owner for? Thanks!

@homeassistant
Copy link
Contributor

Hey there @PhracturedBlue, @tetienne, @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (template) you are listed as a code owner for? Thanks!

@epenet epenet force-pushed the deprecate-pressure-util branch from 9ba1132 to 760b343 Compare September 22, 2022 15:52
@epenet epenet marked this pull request as draft September 22, 2022 16:24
@epenet epenet force-pushed the deprecate-pressure-util branch from 7063c62 to aebf7cc Compare September 23, 2022 06:43
@epenet epenet changed the title Deprecate pressure utility Deprecate utilities Sep 23, 2022
@epenet epenet force-pushed the deprecate-pressure-util branch 2 times, most recently from b37a1e8 to 4f593ef Compare September 28, 2022 12:31
@epenet epenet added the smash Indicator this PR is close to finish for merging or closing label Sep 28, 2022
@epenet epenet marked this pull request as ready for review September 28, 2022 12:42
@epenet epenet force-pushed the deprecate-pressure-util branch from 4f593ef to 38cf36d Compare September 28, 2022 12:43
@epenet epenet mentioned this pull request Sep 28, 2022
23 tasks
@epenet epenet removed docs-missing small-pr PRs with less than 30 lines. labels Sep 28, 2022
@epenet epenet changed the title Deprecate utilities Deprecate conversion utilities Sep 28, 2022
@emontnemery emontnemery merged commit 9c3b40d into home-assistant:dev Sep 28, 2022
@epenet epenet deleted the deprecate-pressure-util branch September 28, 2022 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core deprecation Indicates a breaking change to happen in the future smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants