Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioecowitt 2022.09.2 #78287

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Bump aioecowitt 2022.09.2 #78287

merged 2 commits into from
Sep 13, 2022

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Sep 12, 2022

Breaking change

Proposed change

https://github.com/home-assistant-libs/aioecowitt/releases/tag/2022.09.2

Remove PASSKEY from diagnostics as well

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@pvizeli pvizeli marked this pull request as ready for review September 12, 2022 11:29
@@ -196,6 +196,11 @@
native_unit_of_measurement=PRESSURE_INHG,
state_class=SensorStateClass.MEASUREMENT,
),
EcoWittSensorTypes.PERCENTAGE: SensorEntityDescription(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be split out of this PR into a separate one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No time for that, but I removed the tag for next bugfix release

@pvizeli pvizeli removed this from the 2022.9.3 milestone Sep 12, 2022
@thecode thecode merged commit 0ab19fe into dev Sep 13, 2022
@thecode thecode deleted the aioecowitt-2022.09.1 branch September 13, 2022 19:11
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants