-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for subscribing to config entry changes #77803
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
ecf98be
to
268bc56
Compare
Will write tests after first round of feedback |
What will we use it for? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Frontend: home-assistant/frontend#13585
Proposed change
Add support for subscribing to config entry changes.
The dispatcher is used to get events to the api since config entry state changes
are frequent and we do not want to broadcast them to the event bus.
I didn't use a collection here since config entries are rather noisy with retries
and state changes and I wanted to send everything in a single api so
there wasn't a race between fetching the initial payload and getting callbacks.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: