Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bluetooth le tracker never going not_home #77190

Closed

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 23, 2022

Proposed change

While this is a small fix on its own, this PR is impossible to backport because it relies on significant new functionality added to the Bluetooth integration this week which is only in dev.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

- We now check the time of each service info in the history
  since bleak currently has a change that prevents them from
  disappearing

  See hbldh/bleak#942
@bdraco
Copy link
Member Author

bdraco commented Aug 23, 2022

This won’t work because bleak also doesn’t send updates when the rssi changes so we will always end up removing a device from the tracker if non of the advertisement data changes in 180s

There really isn’t any alternative other than fixing bleak or manually digging into protected bleak data

@bdraco bdraco closed this Aug 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bluetooth LE Tracker no longer scanning or doing anything
2 participants