-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typings to OVO Energy integration #75944
Conversation
10af83e
to
9e268bc
Compare
You will also need to adjust the tests accordingly, and possibly the string.json |
I don't see what that change did, so have reverted back. |
The current implementation is buggy. It assumes that first call doesn't have any data, yet it does! |
a3e6547
to
2fbb9b8
Compare
You have rebased multiple times but you are not adressing my review. The current implementation is still buggy. |
See #75682 as an example for the correct way to implement reauth/reauth_confirm. |
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
This reverts commit 9e268bc.
2fbb9b8
to
9a6b0dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed change
Adds missing typings to OVO Energy integration.
Type of change
Checklist
black --fast homeassistant tests
)If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: