Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update systembridgeconnector to 3.4.4 #75362

Merged
merged 9 commits into from
Aug 15, 2022
Merged

Update systembridgeconnector to 3.4.4 #75362

merged 9 commits into from
Aug 15, 2022

Conversation

timmo001
Copy link
Contributor

@timmo001 timmo001 commented Jul 17, 2022 •
edited
Loading

Proposed change

Updates package to 3.4.4. Also fixes config flow issue raised by #75532

Relevant changelogs:

https://github.com/timmo001/system-bridge/releases/tag/3.4.4
https://github.com/timmo001/system-bridge/releases/tag/3.4.2
https://github.com/timmo001/system-bridge/releases/tag/3.4.1

https://github.com/timmo001/system-bridge/releases

Full changes (includes other changes as monorepo, relevant files are under systembridgeconnector/**/*):

timmo001/system-bridge@3.3.2...3.4.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • 🥈 Silver

To help with the load of incoming pull requests:

@timmo001 timmo001 force-pushed the systembridge-3.4.1 branch from 978a8fe to ef317ac Compare July 17, 2022 15:29
timmo001 added a commit to timmo001/core that referenced this pull request Jul 17, 2022
@timmo001
Merge changes from home-assistant#75362 (#127)
8f66520
timmo001 added a commit to timmo001/core that referenced this pull request Jul 17, 2022
@timmo001
Merge changes from home-assistant#75362 (#128)
455431d 
* Update systembridgeconnector to 3.4.1

* Update to use models in requests

* Fix config flow and use system model
@timmo001 timmo001 force-pushed the systembridge-3.4.1 branch from ef317ac to b3e7b36 Compare July 17, 2022 18:58
timmo001 added a commit to timmo001/core that referenced this pull request Jul 17, 2022
@timmo001
Merge changes from home-assistant#75362 (#128)
17372bd 
* Update systembridgeconnector to 3.4.1

* Update to use models in requests

* Fix config flow and use system model
@timmo001 timmo001 force-pushed the systembridge-3.4.1 branch 3 times, most recently from 1744d81 to 9e4d005 Compare July 23, 2022 00:00
@timmo001 timmo001 changed the title Update systembridgeconnector to 3.4.1 Update systembridgeconnector to 3.4.2 Jul 23, 2022
@timmo001 timmo001 force-pushed the systembridge-3.4.1 branch from fd31e3b to 1f1fca0 Compare July 23, 2022 00:48
timmo001 added a commit to timmo001/core that referenced this pull request Jul 23, 2022
@timmo001
Merge changes from home-assistant#75362 (#128)
e715de0 
* Update systembridgeconnector to 3.4.1

* Update to use models in requests

* Fix config flow and use system model
@timmo001 timmo001 force-pushed the systembridge-3.4.1 branch from 2d261a3 to 1f1fca0 Compare July 23, 2022 00:55
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 25, 2022
@kjake kjake mentioned this pull request Jul 28, 2022
Closed
@Anto79-ops
Copy link

Anto79-ops commented Aug 2, 2022 •
edited
Loading

smash bump 😄 @frenck

@timmo001 timmo001 force-pushed the systembridge-3.4.1 branch from 1f1fca0 to 4c6cac7 Compare August 5, 2022 15:16
@Anto79-ops Anto79-ops mentioned this pull request Aug 5, 2022
Closed
@timmo001 timmo001 requested a review from MartinHjelmare August 5, 2022 16:26
@timmo001 timmo001 force-pushed the systembridge-3.4.1 branch from daf85cd to 6235be1 Compare August 10, 2022 14:38
@Anto79-ops
Copy link

thanks @MartinHjelmare for reviewing! Cheers

@MartinHjelmare
Copy link
Member

Please add a link to a changelog or GitHub commit compare view for the version bump (3.4.4) in the PR description. Thanks!

@timmo001 timmo001 changed the title Update systembridgeconnector to 3.4.2 Update systembridgeconnector to 3.4.4 Aug 15, 2022
@timmo001
Copy link
Contributor Author

Please add a link to a changelog or GitHub commit compare view for the version bump (3.4.4) in the PR description. Thanks!

Done 👍

@timmo001 timmo001 force-pushed the systembridge-3.4.1 branch from f336648 to e0c5f4c Compare August 15, 2022 11:24
MartinHjelmare
MartinHjelmare approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2022.8.5 milestone Aug 15, 2022
@MartinHjelmare MartinHjelmare merged commit 64898af into home-assistant:dev Aug 15, 2022
@timmo001 timmo001 deleted the systembridge-3.4.1 branch August 15, 2022 13:20
balloob pushed a commit that referenced this pull request Aug 16, 2022
@timmo001 @MartinHjelmare @balloob
Update systembridgeconnector to 3.4.4 (#75362)
872b2f5 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@balloob balloob mentioned this pull request Aug 16, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed dependency integration: system_bridge smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
2022.8.5
Development

Successfully merging this pull request may close these issues.

System Bridge config failure
6 participants
@timmo001 @Anto79-ops @MartinHjelmare @frenck @balloob @homeassistant