Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate roku to new entity naming #74819

Merged
merged 14 commits into from
Jul 14, 2022
Merged

Migrate roku to new entity naming #74819

merged 14 commits into from
Jul 14, 2022

Conversation

ctalkington
Copy link
Contributor

@ctalkington ctalkington commented Jul 9, 2022

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added integration: roku small-pr PRs with less than 30 lines. labels Jul 9, 2022
@ctalkington ctalkington marked this pull request as ready for review July 9, 2022 18:01
@ctalkington ctalkington marked this pull request as draft July 9, 2022 18:06
@ctalkington ctalkington force-pushed the ctalkington-patch-1 branch 2 times, most recently from a074df4 to b4fdfbe Compare July 10, 2022 16:13
@ctalkington ctalkington force-pushed the ctalkington-patch-1 branch from 6cd6c75 to c88c932 Compare July 10, 2022 22:58
@ctalkington ctalkington force-pushed the ctalkington-patch-1 branch from c88c932 to 22a0ac7 Compare July 14, 2022 11:53
@ctalkington ctalkington marked this pull request as ready for review July 14, 2022 12:01
@ctalkington ctalkington merged commit 20432cc into dev Jul 14, 2022
@ctalkington ctalkington deleted the ctalkington-patch-1 branch July 14, 2022 12:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants