Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update systembridgeconnector to 3.3.2 #74701

Merged
merged 2 commits into from
Jul 9, 2022

Conversation

timmo001
Copy link
Contributor

@timmo001 timmo001 commented Jul 8, 2022

Proposed change

Updates systembridgeconnector to latest version.

Fix for #74698 from 3.3.0

Due to changes in 3.3.1, the coordinator needed a change to make sure the listener is active before registering as a listener.

For context, 3.3.0 had the fix, but this release contained a reference to the wrong package, so updating to the latest and implementing the small fix above was needed.

Full Changes:

timmo001/system-bridge@3.1.5...3.3.2 (Monorepo so changes will not just be this package)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • 🥈 Silver

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @timmo001 👍

@frenck frenck merged commit e74f7d1 into home-assistant:dev Jul 9, 2022
@timmo001 timmo001 deleted the systembridge-connector-3.3.2 branch July 9, 2022 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to setup Linux System Bridge Host
4 participants