Add System Bridge Media Source #72865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Python cache having issues. Will rebase later |
timmo001
force-pushed
the
system-bridge-mediasource
branch
2 times, most recently
from
96d2c8b to
fd8b508
Compare
PaarthShah
approved these changes
Jun 4, 2022
timmo001
force-pushed
the
system-bridge-mediasource
branch
from
fd8b508 to
34ac1a0
Compare
timmo001
commented
Jun 9, 2022
timmo001
force-pushed
the
system-bridge-mediasource
branch
from
1a50f09 to
d9d4d84
Compare
frenck
added
the
smash
balloob
reviewed
Jun 28, 2022
balloob
reviewed
Jun 28, 2022
balloob
reviewed
Jun 28, 2022
balloob
reviewed
Jun 28, 2022
frenck
removed
the
smash
timmo001
force-pushed
the
system-bridge-mediasource
branch
from
925882e to
f662ec0
Compare
timmo001
force-pushed
the
system-bridge-mediasource
branch
from
973972a to
d6eb26a
Compare
|
Updated package to use futures as suggested https://github.com/timmo001/system-bridge/releases/tag/3.3.1 |
timmo001
commented
Jul 9, 2022
timmo001
force-pushed
the
system-bridge-mediasource
branch
2 times, most recently
from
2aeefcd to
2e41384
Compare
timmo001
force-pushed
the
system-bridge-mediasource
branch
from
2e41384 to
38348ca
Compare
To replace with all avaliable entries under "System Bridge" title
timmo001
force-pushed
the
system-bridge-mediasource
branch
from
2c2850d to
aa65303
Compare
balloob
approved these changes
Aug 16, 2022
| entry: ConfigEntry, | ||
| ) -> str: | ||
| """Build base url for System Bridge media.""" | ||
| return f"http://{entry.data[CONF_HOST]}:{entry.data[CONF_PORT]}/api/media/file/data?apiKey={entry.data[CONF_API_KEY]}" |
There was a problem hiding this comment.
Please split long strings around 88 characters per line.
| domain=DOMAIN, | ||
| identifier=f"{path}/{media_file.name}{ext}", | ||
| media_class=MEDIA_CLASS_DIRECTORY | ||
| if media_file.is_directory or media_file.mime_type is None |
There was a problem hiding this comment.
A ternary operator expression inside an instantiating multi-line call like this is really hard to read. Please rewrite it.
| """Build individual media item.""" | ||
| ext = ( | ||
| f"~~{media_file.mime_type}" | ||
| if media_file.is_file and media_file.mime_type is not None |
There was a problem hiding this comment.
Please don't use ternary operator expressions that span more than one line.
frenck
added
the
noteworthy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds media source to System Bridge integration.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: