Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for announce to play_media #72566

Merged
merged 2 commits into from
May 31, 2022
Merged

Add support for announce to play_media #72566

merged 2 commits into from
May 31, 2022

Conversation

balloob
Copy link
Member

@balloob balloob commented May 26, 2022

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @pvizeli, mind taking a look at this pull request as it has been labeled with an integration (tts) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (media_player) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@marcelveldt
Copy link
Member

Question is if we should provide a default/fallback implementation, given the fact that most media_player implementations will not provide this natively or each integration is going to implement this the same way in the integration code (or supporting library): pause media, play alert, resume media. This can be overridden by a more fine grained approach.

Or at least have this as a feature flag so only useable/visible for platforms that support it ?

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Need dev & end-user docs.

@frenck
Copy link
Member

frenck commented May 30, 2022

Or at least have this as a feature flag so only useable/visible for platforms that support it ?

I kinda agree on that one. I allows for finding the ones that support it.

However, if a media player doesn't support it (but does support playing media), should it ignore alert=true? Or just handle it as a play media (like we do now).

@marcelveldt
Copy link
Member

However, if a media player doesn't support it (but does support playing media), should it ignore alert=true? Or just handle it as a play media (like we do now).

Good question. I think handle it as regular play media is best ?

@frenck
Copy link
Member

frenck commented May 30, 2022

Good question. I think handle it as regular play media is best ?

In that case, we don't need a support flag :)
As that is what it does now.

@marcelveldt
Copy link
Member

In that case, we don't need a support flag :) As that is what it does now.

haha, true. So what you're saying is: do not handle the request if a player/integration does not have support for alert feature.

@balloob balloob added this to the 2022.6.0 milestone May 30, 2022
@balloob balloob changed the title Add support for alert to play_media Add support for announce to play_media May 30, 2022
@balloob balloob merged commit 99f3ca1 into dev May 31, 2022
@balloob balloob deleted the add-alert-media-player branch May 31, 2022 03:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants