-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for announce to play_media #72566
Conversation
Hey there @pvizeli, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Question is if we should provide a default/fallback implementation, given the fact that most media_player implementations will not provide this natively or each integration is going to implement this the same way in the integration code (or supporting library): pause media, play alert, resume media. This can be overridden by a more fine grained approach. Or at least have this as a feature flag so only useable/visible for platforms that support it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM
Need dev & end-user docs.
I kinda agree on that one. I allows for finding the ones that support it. However, if a media player doesn't support it (but does support playing media), should it ignore alert=true? Or just handle it as a play media (like we do now). |
Good question. I think handle it as regular play media is best ? |
In that case, we don't need a support flag :) |
haha, true. So what you're saying is: do not handle the request if a player/integration does not have support for alert feature. |
Breaking change
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: