Skip to content

Conversation

akloeckner
Copy link
Contributor

@akloeckner akloeckner commented May 24, 2022

Proposed change

This also adds the this variable to trigger-based templates. The code is basically taken from automation and implanted here.

follow-up for #65201

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @PhracturedBlue, @tetienne, @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (template) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@akloeckner
Copy link
Contributor Author

@emontnemery, I believe you were quite active in this field, recently. So, maybe, you're to be involved naturally...

@MartinHjelmare MartinHjelmare changed the title add this variables to trigger-based templates Add this variables to trigger-based templates May 24, 2022
@akloeckner akloeckner changed the title Add this variables to trigger-based templates Add this variable to trigger-based templates May 24, 2022
akloeckner added a commit to akloeckner/home-assistant.io that referenced this pull request May 24, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 23, 2022
@akloeckner
Copy link
Contributor Author

.

@github-actions github-actions bot removed the stale label Jun 24, 2022
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @akloeckner 👍

@emontnemery emontnemery merged commit aa314a0 into home-assistant:dev Jun 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants