Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary update_before_add from ZHA #71010

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

dmulcahey
Copy link
Contributor

@dmulcahey dmulcahey commented Apr 28, 2022

Breaking change

No

Proposed change

Continuing the work on fixing ZHA initialization and while handling this comment: #70956 (comment) I discovered that several platforms were still calling update_before_add in ZHA which causes additional unnecessary network reads. The only place the update is needed is for group entities since their state is derived from the member states. This PR fixes the test comment above and corrects the extra network reads.

I am going to take an additional pass after the beta (for next months release) to verify all calls against all clusters in the tests to prevent something like this from happening again.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@dmulcahey dmulcahey added this to the 2022.5.0 milestone Apr 28, 2022
Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frenck frenck merged commit 1eb5316 into home-assistant:dev Apr 28, 2022
balloob pushed a commit that referenced this pull request Apr 28, 2022
* Additional streamlining for ZHA entity init

* fix tests
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2022
@dmulcahey dmulcahey deleted the dm/zha-additional-init-fixes branch November 11, 2022 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants