Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squeezebox grouping #70962

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Squeezebox grouping #70962

merged 3 commits into from
Apr 29, 2022

Conversation

rajlaud
Copy link
Contributor

@rajlaud rajlaud commented Apr 28, 2022

Breaking change

This PR updates the squeezebox player synchronization framework to use the platform-level services media_player.join and media_player.unjoin. The list of synchronized players is now stored in the group_members state attribute.

Warn regarding depreciation of squeezebox.sync and squeezebox.unsync, which will be removed in two releases in favor of the new platform-level services.

The sync_group state attribute is deprecated in favor of group_members, and will be removed in two releases.

Proposed change

Bring the squeezebox sync framework up to date with current implementation of multi-room audio at the media_player platform level.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

rajlaud added a commit to rajlaud/home-assistant.io that referenced this pull request Apr 28, 2022
Remove reference to deprecated service calls `squeezebox.sync` and `squeezebox.unsync`. Use platform-level `media_player.join` and `media_player.unjoin` instead. See home-assistant/core#70962
@rajlaud rajlaud marked this pull request as ready for review April 28, 2022 04:44
@rajlaud rajlaud marked this pull request as draft April 28, 2022 05:07
@rajlaud rajlaud marked this pull request as ready for review April 28, 2022 06:59
@frenck
Copy link
Member

frenck commented Apr 28, 2022

The breaking change should mention the deprecation of the sync_group state attribute too (as it's replaced by the group_members attribute).

Otherwise: Tested locally and works as expected ✅

@balloob balloob merged commit c7d3446 into home-assistant:dev Apr 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2022
@rajlaud rajlaud deleted the squeezebox-grouping branch May 27, 2022 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants