-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore ONVIF sensors #70393
Restore ONVIF sensors #70393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments (mostly questions that I couldn't be sure either way)
Hoepfully resolved/answered your comments/questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my point of view, this looks ok now, but probably would benefit from a 2nd review by someone else.
I removed the usage of |
Proposed change
Add ability to restore sensors to ONVIF. On startup we pull data from the camera, but some states do not get returned until they change. This allows us to continue creating entities that were previously seen on the device and restore the last known state until it changes again.
This also fixes a bug introduced in #69708 where the sensor states were never updated.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: