Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zwave-js-server-python to 0.35.3 #70357

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

raman325
Copy link
Contributor

Proposed change

Currently when the lib doesn't recognize a notification event it raises an exception which causes the config entry to reload. This is not a great behavior, so we fixed it in the lib and added better handling here.

Lib changes: https://github.com/home-assistant-libs/zwave-js-server-python/releases/tag/0.35.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@raman325
Copy link
Contributor Author

I have not tested this, nor do I have time to at the moment. @MartinHjelmare @cgarwood @kpine can one of you test? I am pretty sure it will be fine but at worst it will require minimal changes which someone is free to push to the PR

@raman325 raman325 added this to the 2022.4.7 milestone Apr 21, 2022
@MartinHjelmare
Copy link
Member

I'll test it.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tested and working for me.

@MartinHjelmare MartinHjelmare changed the title Bump zwave-js-server-python to 0.35.3 to fix bug Bump zwave-js-server-python to 0.35.3 Apr 21, 2022
@MartinHjelmare MartinHjelmare merged commit 220cb57 into home-assistant:dev Apr 21, 2022
@raman325 raman325 deleted the notification branch April 21, 2022 13:05
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HA loses connection to zwavejs2mqtt when receiving a CC Multilevel Switch notification
4 participants