-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump zwave-js-server-python to 0.35.3 #70357
Conversation
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( |
I have not tested this, nor do I have time to at the moment. @MartinHjelmare @cgarwood @kpine can one of you test? I am pretty sure it will be fine but at worst it will require minimal changes which someone is free to push to the PR |
I'll test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Tested and working for me.
Proposed change
Currently when the lib doesn't recognize a
notification
event it raises an exception which causes the config entry to reload. This is not a great behavior, so we fixed it in the lib and added better handling here.Lib changes: https://github.com/home-assistant-libs/zwave-js-server-python/releases/tag/0.35.3
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: