Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated remote classes #7011

Merged
merged 4 commits into from
Apr 10, 2017
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 10, 2017

Description:

This removes the deprecated remote classes. The helper methods to call the API are still in place.

  • Removed remote.HomeAssistant, remote.EventBus, remote.StateMachine, connect_remote_events, disconnect_remote_events and the API /api/event_forwarding

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link

@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @rmkraus and @philipbl to be potential reviewers.

@balloob balloob merged commit d081e5a into dev Apr 10, 2017
@balloob balloob deleted the remove-deprecated-remote-classes branch April 10, 2017 16:04
@balloob balloob mentioned this pull request Apr 21, 2017
@AddoSolutions
Copy link

This breaks quite a few docs, a few notables ones are:

https://home-assistant.io/developers/python_api/
https://home-assistant.io/developers/multiple_instances/

Not sure how to do remote instances now, any suggestions?

Originally it was said to run it the following way in a slave.py file:

import homeassistant.remote as remote
import homeassistant.bootstrap as bootstrap

# Location of the Master API: host, password, port.
# Password and port are optional.
remote_api = remote.API("127.0.0.1", "password", 8124)

# Initialize slave
hass = remote.HomeAssistant(remote_api)

# To add an interface to the slave on localhost:8123
bootstrap.setup_component(hass, 'frontend')

hass.start()
hass.block_till_stopped()

@cmsimike
Copy link
Contributor

cmsimike commented Jun 6, 2017

@AddoSolutions
I don't think remote instances work anymore. I tried to have a similar setup but with the removal of remote.HomeAssistant(...), the only option we have left is the MQTT Event Stream but that doesn't do what I want (it only pushes events from one hass to another, it doesn't allow me to talk about entities in one hass instance from another).

I was actually just talking in the gitter chat about this.

@balloob
Copy link
Member Author

balloob commented Jun 7, 2017

I have updated the docs to mark or remove the parts that are no longer available.

This remote connection was very unstable and at some point broken with no developer fixing it and taking ownership. A future implementation should not be part of the main repo but should come as it's own package.

@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants