Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set source & sound mode at start in media player reproduce state #70064

Conversation

thecode
Copy link
Member

@thecode thecode commented Apr 14, 2022

Proposed change

Follow up of #70055
If device current state does not support of one the scene sound attributes it may fail if the source or sound mode are set last.
For example:
Current sound mode is "external sound output", has no volume set/mute
Captured scene state was "internal speaker" which supports volume set and it exists in the scene.
Setting the volume while current state is "external sound output" may fail because the device current mode does not allow it.
If we first set the sound mode we guarantee that the device state is the same as when the scene was captured.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (media_player) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@thecode thecode changed the title Set sound mode at start in media player reproduce state Set source & sound mode at start in media player reproduce state Apr 15, 2022
@balloob balloob merged commit 1a2a3b5 into home-assistant:dev Apr 15, 2022
@balloob balloob added this to the 2022.4.5 milestone Apr 15, 2022
@thecode thecode deleted the media-player-reproduce-state-sound-mode-first branch April 15, 2022 17:50
@frenck frenck mentioned this pull request Apr 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants