-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Plugwise select and add regulation_mode selector #69210
Conversation
Hey there @CoMPaTech, @brefra, @frenck, mind taking a look at this pull request as it has been labeled with an integration ( |
|
8173a21
to
9d2a0be
Compare
@frenck updated as suggested, please re-review. |
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@frenck Tnx for reviewing and updating! Now let's see if I can understand what your changes amount too... Yes, the changes are clear :) |
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Should we also remove the line |
@bouwew If you remove it from coveragerc now, it will need coverage to justify that now as well. |
Ok clear. Then let's leave it and we'll add testcoverage via a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bouwew 👍
Great! Thanks for the review-feedback, and merging :) |
Proposed change
Refactor select.py to allow for easy implementation of more selectors.
Add a regulation_mode selector, only available on the Adam.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: