Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Plugwise select and add regulation_mode selector #69210

Merged
merged 8 commits into from
May 11, 2022

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Apr 3, 2022

Proposed change

Refactor select.py to allow for easy implementation of more selectors.
Add a regulation_mode selector, only available on the Adam.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @CoMPaTech, @brefra, @frenck, mind taking a look at this pull request as it has been labeled with an integration (plugwise) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@CoMPaTech
Copy link
Contributor

CoMPaTech commented Apr 3, 2022

We should consider adding tests for the regulation mode if we don't want to fall back in coverage
Frencks comments will change this

homeassistant/components/plugwise/entity.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/select.py Outdated Show resolved Hide resolved
@bouwew bouwew force-pushed the pw_refactor_select branch from 8173a21 to 9d2a0be Compare April 10, 2022 09:31
@bouwew
Copy link
Contributor Author

bouwew commented Apr 10, 2022

@frenck updated as suggested, please re-review.

@bouwew bouwew requested a review from frenck April 11, 2022 09:31
homeassistant/components/plugwise/select.py Show resolved Hide resolved
homeassistant/components/plugwise/select.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/select.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/select.py Outdated Show resolved Hide resolved
homeassistant/components/plugwise/select.py Outdated Show resolved Hide resolved
bouwew and others added 5 commits May 11, 2022 09:40
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@bouwew
Copy link
Contributor Author

bouwew commented May 11, 2022

@frenck Tnx for reviewing and updating! Now let's see if I can understand what your changes amount too...

Yes, the changes are clear :)

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@bouwew
Copy link
Contributor Author

bouwew commented May 11, 2022

Should we also remove the line homeassistant/components/plugwise/select.py from .coveragerc so we can create a test-file later?
Or does this result in the blocking of this PR?

@MartinHjelmare MartinHjelmare changed the title Plugwise: refactor select.py and add regulation_mode selector Refactor Plugwise select and add regulation_mode selector May 11, 2022
@frenck
Copy link
Member

frenck commented May 11, 2022

@bouwew If you remove it from coveragerc now, it will need coverage to justify that now as well.

@bouwew
Copy link
Contributor Author

bouwew commented May 11, 2022

Ok clear. Then let's leave it and we'll add testcoverage via a separate PR.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bouwew 👍

@frenck frenck merged commit 2d5a82d into home-assistant:dev May 11, 2022
@bouwew bouwew deleted the pw_refactor_select branch May 11, 2022 08:53
@bouwew
Copy link
Contributor Author

bouwew commented May 11, 2022

Great! Thanks for the review-feedback, and merging :)

@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants