Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rokuecp to 0.16.0 #68822

Merged
merged 4 commits into from
Apr 1, 2022
Merged

Update rokuecp to 0.16.0 #68822

merged 4 commits into from
Apr 1, 2022

Conversation

ctalkington
Copy link
Contributor

@ctalkington ctalkington commented Mar 29, 2022

Breaking change

Proposed change

resolves issues with multiple rokus via dns hostname

https://github.com/ctalkington/python-rokuecp/releases/tag/0.16.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@ctalkington ctalkington force-pushed the ctalkington-rokuecp-0160 branch from aff133f to e4f4d24 Compare April 1, 2022 01:12
@ctalkington ctalkington added this to the 2022.4.0 milestone Apr 1, 2022
@ctalkington ctalkington marked this pull request as ready for review April 1, 2022 01:16
@frenck frenck merged commit 165e79b into dev Apr 1, 2022
@frenck frenck deleted the ctalkington-rokuecp-0160 branch April 1, 2022 11:39
balloob pushed a commit that referenced this pull request Apr 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform roku does not generate unique IDs.
5 participants