Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase zwave_js add-on start attempts before timeout #68736

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Mar 27, 2022

Breaking change

Proposed change

  • To check if the server is running in the add-on after starting the add-on we attempt to connect to the server and get the server version. This is done in a loop with a 5 second sleep in each round and also a 10 second timeout on the request. If we don't get an ok answer after all the rounds we consider the add-on start to have failed with a timeout error.
  • Some slower hosts seem to need more time to start the driver and server. Fix this by increasing loop rounds to 40 from 4, increasing the minimum timeout time to 200 seconds from 20 seconds, and the maximum timeout time to 600 seconds from 60 seconds.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare requested a review from a team as a code owner March 27, 2022 09:45
@probot-home-assistant probot-home-assistant bot added integration: zwave_js small-pr PRs with less than 30 lines. labels Mar 27, 2022
@probot-home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare added this to the 2022.3.7 milestone Mar 27, 2022
@MartinHjelmare MartinHjelmare merged commit ea2b5a8 into home-assistant:dev Mar 27, 2022
@MartinHjelmare MartinHjelmare deleted the increase-zwave_js-add-on-start-timeout branch March 27, 2022 10:30
@balloob balloob modified the milestones: 2022.3.7, 2022.3.8 Mar 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants