Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix utility meter restore state #66490

Merged
merged 12 commits into from
Feb 15, 2022

Conversation

dgomes
Copy link
Contributor

@dgomes dgomes commented Feb 13, 2022

Breaking change

Proposed change

Checks restored value is a number

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title Fix #63874 Fix utility meter restore state Feb 14, 2022
@MartinHjelmare
Copy link
Member

Why does the user has a string "None" stored for this attribute? We should probably fix that if there's some code that allows that.

@dgomes
Copy link
Contributor Author

dgomes commented Feb 14, 2022

Why does the user has a string "None" stored for this attribute? We should probably fix that if there's some code that allows that.

This is an extreme edge case, moving backwards in time:

  • Last period is "None" when restored
  • Last period is None when reset happens and the current state is None
  • state is None when the sensor is created and hasn't received any status update from the source sensor yet (first update is detected using state = None)

@dgomes
Copy link
Contributor Author

dgomes commented Feb 14, 2022

last commit might solve the root cause, but will not address existing installs

@dgomes
Copy link
Contributor Author

dgomes commented Feb 14, 2022

increased coverage to 100%

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2022.2.7 milestone Feb 15, 2022
@MartinHjelmare MartinHjelmare merged commit b211a1f into home-assistant:dev Feb 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utility_meter sensor fails during Homeassistant startup on 'None' value
4 participants