Fix mesh role for Fritz old devices #66369
Conversation
probot-home-assistant
bot
added
bugfix
integration: fritz
small-pr
|
Hey there @mammuth, @AaronDavidSchneider, @mib1185, mind taking a look at this pull request as it has been labeled with an integration ( |
chemelli74
changed the title
| self.mesh_role = MeshRoles.SLAVE | ||
| return | ||
| if ( | ||
| "Hosts1" not in self.connection.services |
There was a problem hiding this comment.
Device details should be handled by the library.
There was a problem hiding this comment.
This is not a low level call, I don't think the library should be responsible for it.
We have the list of available services for each device, and based on that we decide what to do on HA side.
Simone
There was a problem hiding this comment.
The point of the library is that it should handle device variations and abstract that.
There was a problem hiding this comment.
So you would like to have a method like mesh_supported() in the library to replace this if ?
There was a problem hiding this comment.
Yes, that sounds good. 👍
There was a problem hiding this comment.
Let's see if the author of the library agree; anyway it will slow down a lot the fix :-(
There was a problem hiding this comment.
Moving to draft as we are now waiting for kbr/fritzconnection#145
There was a problem hiding this comment.
I am going to merge this PR for the hot fix.
We can update using the new function from the lib once it's been released.
Proposed change
Devices with old firmware ( <= 6.x ) doens't support mesh network.
This PR fix the mesh role.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: