Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new radon device class #66149

Closed

Conversation

jrbeilke
Copy link

@jrbeilke jrbeilke commented Feb 9, 2022

Proposed change

Using the Airthings integration with an Airthings View Plus, which includes Radon monitoring, but Home Assistant lacks a device class for handling Radon sensor and units. Following some of the other examples (ie. #54075 for air quality devices) I've attempted to add a new Radon device class.

The Airthings API tracks Radon in becquerels (Bq/m³), but in the US picocuries (pCi/L) are more commonly used, and the new Radon device class for Home Assistant handles the conversion based on imperial vs metric units.
https://help.airthings.com/en/articles/3119854-radon-what-is-the-difference-between-pci-l-and-bq-m3

Airthings has a number of different devices now for tracking Radon (ie. Wave Radon, Wave Plus, and View Radon), and it would seem that other device integrations would benefit from this Radon device class as well.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hi @jrbeilke,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@frenck
Copy link
Member

frenck commented Feb 9, 2022

Has this addition been approved via an architectural discussion?
This changes our entity model, and requires to be pre-approved before this can be added.

@jrbeilke
Copy link
Author

jrbeilke commented Feb 9, 2022

Has this addition been approved via an architectural discussion?
This changes our entity model, and requires to be pre-approved before this can be added.

Ah missed that. Here is a new architectural discussion for adding a radon device class: home-assistant/architecture#732

@MartinHjelmare MartinHjelmare marked this pull request as draft February 12, 2022 22:14
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label May 13, 2022
@github-actions github-actions bot closed this May 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants