Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce System Bridge load on server #65794

Merged

Conversation

timmo001
Copy link
Contributor

@timmo001 timmo001 commented Feb 5, 2022

Proposed change

Updates to new schema and calls specific methods/endpoints from controller to reduce load on server. Package handles these changes in data.

Package changes:
timmo001/system-bridge-connector-py@v2.2.3...v2.3.1

Type of change

  • Dependency upgrade

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • 🥈 Silver

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title System Bridge - Reduce load on server Reduce System Bridge load on server Feb 5, 2022
Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MartinHjelmare MartinHjelmare merged commit acb7e24 into home-assistant:dev Feb 5, 2022
@timmo001 timmo001 deleted the system-bridge-reduce-calls branch February 6, 2022 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants