-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move remaining keys to setup.cfg
#65154
Conversation
* Remove unused constants * Remove deprecated test_suite key
* Only include homeassistant*, not script* * Add long_desc_content_type * Remove license file (auto-included by setuptools + wheels)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Pip 21.2 doesn't support editable installs without it.
I did some more testing to make sure everything still works as expected. Turns out we can't remove Not required, but I would suggest to cherry-pick it, too. That way we do all of them together. I don't expect any issues, but if someone still encounters any, please let me know. I should be able to help. |
* Move metadata keys * Move options * Delete setup.py * Remove unused constants * Remove deprecated test_suite key * Improve metadata * Only include homeassistant*, not script* * Add long_desc_content_type * Remove license file (auto-included by setuptools + wheels) * Add setup.py Pip 21.2 doesn't support editable installs without it.
Proposed change
Complete the move from
setup.py
tosetup.cfg
.Depends on #65145, since this PR removes
setup.py
completely and thuspython setup.py sdist bdist_wheel
won't work.Additional improvements
long_description_content_type
keylicense_file
key andLICENSE.md
fromMANIFEST.in
. Bothsetuptools
andwheel
automatically include it already. The newlicense_files
key would only be necessary if the filename didn't match the default glob pattern. https://setuptools.pypa.io/en/latest/references/keywords.html?highlight=license_files#keywordsfind_package
from excludetests*
to includehomeassistant*
. At the moment all python files inside thescript
folder are included in the final package. Unless I'm missing something, those don't need to be included. The Home-Assistant scripts are still included (homeassistant/scripts
).https://github.com/home-assistant/core/tree/dev/script
Full list of files which won't be included with these changes (compared to what is included now)!
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: