-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Elmax code quality #61273
Improve Elmax code quality #61273
Conversation
Linting review
…parent. Update internal entity state just after transitory state update.
Reference Platform constant Co-authored-by: Marvin Wichmann <marvin@fam-wichmann.de>
Rely on already-present templating constants Co-authored-by: Marvin Wichmann <marvin@fam-wichmann.de>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
…s, after 2 and 5 seconds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks Martin for your review! |
I just added a few more commits that have been pending from a previous review. We should finally be on the right track this time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks, @albertogeniola 👍
Thanks to you guys for the great help you provided. |
Proposed change
The Elmax integration has been merged in #59321, but some improvements/edited have been suggested by reviewers. This PR addresses such requests. In particular this PR changes the following:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: