Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Elmax code quality #61273

Merged
merged 51 commits into from
Dec 27, 2021

Conversation

albertogeniola
Copy link
Contributor

Proposed change

The Elmax integration has been merged in #59321, but some improvements/edited have been suggested by reviewers. This PR addresses such requests. In particular this PR changes the following:

  • Removes useless index & visibility extra attributes from ElmaxEntity
  • Simplifies the ElmaxEntity logic by leveraging the CoordinatorEntity (Thanks @frenck !)
  • Simplifies tests logic (thanks @MartinHjelmare !)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

albertogeniola and others added 27 commits December 4, 2021 19:53
…parent.

Update internal entity state just after transitory state update.
Reference Platform constant

Co-authored-by: Marvin Wichmann <marvin@fam-wichmann.de>
Rely on already-present templating constants

Co-authored-by: Marvin Wichmann <marvin@fam-wichmann.de>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@albertogeniola
Copy link
Contributor Author

Looks good!

Thanks Martin for your review!

homeassistant/components/elmax/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/elmax/config_flow.py Outdated Show resolved Hide resolved
@albertogeniola
Copy link
Contributor Author

I just added a few more commits that have been pending from a previous review. We should finally be on the right track this time!

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks, @albertogeniola 👍

@frenck frenck merged commit 1f425b1 into home-assistant:dev Dec 27, 2021
@albertogeniola
Copy link
Contributor Author

Thanks to you guys for the great help you provided.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2021
@albertogeniola albertogeniola deleted the elmax-integration-refactor branch January 13, 2022 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants